chore: remove unused DialogFooter export from dialog component#213
Open
andrerfneves wants to merge 1 commit into
Open
chore: remove unused DialogFooter export from dialog component#213andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
DialogFooter is defined in the dialog.tsx shadcn/ui component but no consumer imports it. The component definition remains in the file (consistent with the pattern used in PR #203 and PR #207 for other unused dialog subcomponent exports), only the redundant export entry is removed. Verified: grep confirms no files import DialogFooter from anywhere in the codebase.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
DialogFooterexport from the dialog shadcn/ui component. The component definition remains in the file (consistent with the pattern used in PR #203 and PR #207 for other unused dialog subcomponent exports), only the redundant export entry is removed.Why
DialogFooteris defined indialog.tsxand exported, but no external code imports it. Keeping unnecessary exports:This follows the same cleanup pattern as:
DialogPortalandDialogOverlayfrom exportsDialogCloseandDialogTriggerfrom exportsChanges
src/components/ui/dialog.tsx: RemovedDialogFooterfrom theexport { ... }block. The component definition remains in the file.Verification
DialogFooterfrom anywhere in the codebase