docs(deployment): add restart policy to nginx service in SSL docker-compose example#216
Open
andrerfneves wants to merge 1 commit into
Open
docs(deployment): add restart policy to nginx service in SSL docker-compose example#216andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
…ompose example The nginx reverse proxy service in the production SSL/TLS docker-compose example was missing a restart policy. Without it, Docker will not automatically restart the container if it crashes or the host reboots. Added `restart: unless-stopped` for consistency with the lightning-decoder service in the same example and the best practice pattern used throughout the document.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
restart: unless-stoppedpolicy to the nginx reverse proxy service in the SSL/TLS production docker-compose example inDEPLOYMENT_DOCKER.md.Why
The nginx service was missing a restart policy, meaning Docker would not automatically restart it if the container crashes or the host reboots. This is inconsistent with:
lightning-decoderservice in the same example (which already hasrestart: unless-stopped)restart: unless-stopped)Changes
DEPLOYMENT_DOCKER.md: Addedrestart: unless-stoppedto the nginx service definition in the SSL/TLS production docker-compose exampleTest Plan