docs(deployment): use SHA tagging in GitHub Actions Docker example#221
Open
andrerfneves wants to merge 1 commit into
Open
docs(deployment): use SHA tagging in GitHub Actions Docker example#221andrerfneves wants to merge 1 commit into
andrerfneves wants to merge 1 commit into
Conversation
Replace the bare :latest tag with both :latest and :${{ github.sha }}
tags in the GitHub Actions CI example in DEPLOYMENT_DOCKER.md. This
is consistent with PR #214, which made the same fix for the GitLab CI
example.
Using :latest alone makes it impossible to trace which commit a running
container corresponds to. Adding a SHA-based tag creates uniquely
identifiable and traceable image references, while keeping :latest as
a convenience alias for the most recent build.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the GitHub Actions CI example in
DEPLOYMENT_DOCKER.mdto use commit SHA-based tagging alongside:latest, consistent with the approach taken for the GitLab CI example in PR #214.Why
The GitHub Actions example used only
tags: yourusername/lightning-decoder:latest. Tagging images solely with:latestmakes it impossible to trace which commit a running container corresponds to. This is a well-known anti-pattern for production deployments.This change is the GitHub Actions counterpart of PR #214, which fixed the same issue in the GitLab CI example.
Changes
DEPLOYMENT_DOCKER.md: Changed the GitHub ActionsBuild and pushstep from a single:latesttag to both:latestand:${{ github.sha }}tags::latest— retained as a convenience alias for the most recent build:${{ github.sha }}— unique, traceable image reference per commitTest Plan