Fix deprecations and upgrade OSS, Retrofit#212
Open
riggaroo wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs dependency updates and migrates various spatial and UI components to newer APIs. Specifically, it updates the spatial Orbiter usages to use anchorPoint and DpVolumeOffset, replaces MovePolicy with movable and transformingMovable modifiers, and transitions bottom sheets to use rememberBottomSheetState. Feedback on these changes highlights a performance anti-pattern in CameraZoomToolbar.kt, where text layout measurement is executed inside a recomposing lambda; it is recommended to calculate and remember this width at the parent level instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to new XR APIs, migrate to new retrofit version and OSS version.