Add Full Bleed Snap Scrolling Glance Canonical Layout#418
Conversation
- Implemented FullBleedImageLayout featuring edge-to-edge layout with VerticalScrollMode.SnapScroll - Created FullBleedImageAppWidget receiver with FakeImageGridDataRepository - Configured adaptive text sizing via FontUtils, scaling titles and captions dynamically - Set limits to exactly 5 items and made widget collapsible down to 2x1 cell size - Configured edge-to-edge properties, drawable resources, and registered in CanonicalLayoutActivity - Bumped Glance dependency to 1.3.0-alpha01 and set compileSdk to 37
…geLayout - Decouple the linear gradient background scrim from the text column into flat independent sibling layers inside GalleryItemCard. - Establish a reliable size-class dependent height (100.dp / 140.dp) for the bottom scrim drawable. - Promote LongTextLayoutDimensions to WidgetTextDimensions to allow shared metrics. - Add sample_scrim_gradient drawable. - Add truncateTextToFit helper in FontUtils.
…optimize text-scaling thresholds, and refresh the widget fallback preview image
- Flatten composition tree by removing redundant key(LocalSize.current) wrappers.\n- Hoist LocalSize and LocalContext lookups to FullBleedImageLayout to optimize recompositions.\n- Enable stable list item keying with Glance LazyColumn itemId optimization.\n- Refactor FakeImageGridDataRepository to use non-blocking coroutineScope instead of runBlocking.\n- Sanitize drawables and preview layout bindings, deleting duplicative png assets.
… row image scaling
…sitory, FontUtils, and xlarge dimens.xml
…review and deletion
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'Full Bleed Snap Scrolling' widget sample using Glance, which includes updating the Glance library version, adding the widget receiver to the manifest, and implementing the full-bleed layout with snap scrolling. Feedback focuses on preventing runtime crashes on older devices (down to minSdk 21) by replacing @RequiresApi annotations with runtime SDK checks in CanonicalLayoutActivity and FullBleedImageAppWidget. Additionally, it is recommended to directly implement the gradient scrim workaround in FullBleedImageLayout rather than just describing it in a comment.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
LGTM though perhaps look at 'High Priority' asks from gemini code assist. |
2 participants
Add full bleed snap scrolling Glance Canonical Layout