Skip to content

restore adaptive app icon by deleting redundant ic_launcher icons#419

Merged
ashnohe merged 2 commits into
mainfrom
tai
Jun 4, 2026
Merged

restore adaptive app icon by deleting redundant ic_launcher icons#419
ashnohe merged 2 commits into
mainfrom
tai

Conversation

@ashnohe
Copy link
Copy Markdown
Contributor

@ashnohe ashnohe commented Jun 4, 2026

Was:
Screenshot 2026-06-04 at 10 24 25 AM

(or the default bugdroid)

Now:
Screenshot 2026-06-04 at 10 24 56 AM

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up unused vector drawables and adaptive icons, removes an outdated TODO comment in FullBleedImageLayout.kt, and updates the small icon resource in SnackbarNotificationManager.kt to R.drawable.small_icon. Regarding the feedback, a redundant call to setSmallIcon was identified in SnackbarNotificationManager.kt since the base notification builder already configures this icon.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

val orderText = "Your order is being placed"
return buildBaseNotification(appContext, INITIALIZING)
.setSmallIcon(R.drawable.ic_launcher_foreground)
.setSmallIcon(R.drawable.small_icon)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This call to setSmallIcon(R.drawable.small_icon) is redundant because buildBaseNotification(appContext, INITIALIZING) already sets the small icon to R.drawable.small_icon on line 226. You can safely remove this line.

@ashnohe ashnohe merged commit 99ae4c7 into main Jun 4, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants