chore: remove outdated TODO already implemented in VideoPlayerScreen#224
Open
clown6613 wants to merge 1 commit into
Open
chore: remove outdated TODO already implemented in VideoPlayerScreen#224clown6613 wants to merge 1 commit into
clown6613 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes a TODO comment regarding handling loading and error states in the VideoPlayerScreen component. No review comments were provided, so there is no feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
pflammertsma
approved these changes
Jun 18, 2026
Member
|
Indeed; the states were added here: https://github.com/android/tv-samples/pull/168/changes#diff-7b344a6e5e297ce690c55b06dab841bb02a31f596dc3dfed24ed054d5351d058R94 Thanks for catching! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the obsolete
// TODO: Handle Loading & Error statescomment inVideoPlayerScreen.Why
The
when (uiState)block directly below the comment already handles allVideoPlayerScreenUiStatecases —Loading,Error, andDone.The TODO was left behind after the states were implemented by #168 and is now misleading.
Removing it keeps the code aligned with its actual behavior.
Changes
VideoPlayerScreen.kt.No functional changes.