GH-49482: [C++][FlightRPC][ODBC] Fix inconsistent SQLGetInfo values in global connection#50021
Open
vanshaj2023 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Component: C++
Component: FlightRPC
CI: Extra: C++
lidavidm
reviewed
May 25, 2026
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Also CC @alinaliBQ
Comment on lines
+398
to
+399
| bool supported = | ||
| reinterpret_cast<BooleanScalar*>(scalar->child_value().get())->value; |
Member
There was a problem hiding this comment.
Maybe we can use checked_cast from arrow/util/checked_cast.h?
Member
There was a problem hiding this comment.
It seems there's some failing tests - some more test cases need updating?
github-actions
Bot
added
awaiting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SQL_DDL_SCHEMAcase now reads the boolean scalar to conditionally setSQL_DROP_SCHEMAandSQL_CREATE_SCHEMAto0when unsupported, instead of always writing non-zero valuesSQL_DDL_TABLEcase applies the same pattern forSQL_DROP_TABLEandSQL_CREATE_TABLESQL_CATALOG_AT_STARTchanged to useSetDefaultIfMissingso it does not overwriteSQL_CATALOG_LOCATIONalready set byARROW_SQL_CATALOG_TERM, eliminating an ordering-dependent conflictConnectionInfoHandleTestback toConnectionInfoTestHow to test
TestSQLGetInfoCatalogLocation,TestSQLGetInfoDropSchema,TestSQLGetInfoDropTablewith both mock server and global connection fixtureCloses #49482