framework-jobs,server: fix password obfuscation for job result and password with display=false

[shwstppr]

Description

Fixes #13387

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (a3970bb) to head (eb4dd42).
⚠️ Report is 5 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...stack/framework/jobs/impl/AsyncJobManagerImpl.java	82.35%	1 Missing and 2 partials ⚠️
...om/cloud/network/element/VirtualRouterElement.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #13388      +/-   ##
============================================
- Coverage     16.26%   16.26%   -0.01%     
+ Complexity    13434    13433       -1     
============================================
  Files          5666     5667       +1     
  Lines        500645   500676      +31     
  Branches      60801    60799       -2     
============================================
  Hits          81426    81426              
- Misses       410112   410142      +30     
- Partials       9107     9108       +1     

Flag	Coverage Δ
uitests	4.14% <ø> (-0.01%)	⬇️
unittests	17.11% <77.77%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18300

[harikrishna-patnala]

LGTM, verified the fix as well.

I could reproduce the issue with a stopped VR.

After applying the fix

1. created an instance in stopped state, let the VR in stopped state too
2. reset the password, no error observed
3. started the instance and I could see the password in the Virtual router.