[CORE] Hide gflags namespace symbols in native core#12536
Open
wangxinshuo-bolt wants to merge 1 commit into
Open
[CORE] Hide gflags namespace symbols in native core#12536wangxinshuo-bolt wants to merge 1 commit into
wangxinshuo-bolt wants to merge 1 commit into
Conversation
wangxinshuo-bolt
marked this pull request as ready for review
July 16, 2026 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The native core already links gflags, but its implementation is usually built in the
googlenamespace, which is already hidden by the version script. Thegflagsnamespace is normally only an alias and does not introduce additional symbols.However, when gflags is built with
gflagsas its primary namespace, those symbols may be exported. This PR hidesgflags::*as well, making the symbol isolation work for both configurations.How was this patch tested?
readelf/nmto verify that gflags namespace symbols are not exported from the resulting shared library.Was this patch authored or co-authored using generative AI tooling?
Yes.
Generated-by: Codex GPT-5