[GLUTEN-11550][VL] Disable GlutenExplainSuite in Spark 4.x#12546
Open
zml1206 wants to merge 1 commit into
Open
[GLUTEN-11550][VL] Disable GlutenExplainSuite in Spark 4.x#12546zml1206 wants to merge 1 commit into
zml1206 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Velox backend Spark 4.x unit-test settings to disable GlutenExplainSuite (since it asserts Spark-specific physical plan / JVM codegen details) and to re-enable several previously excluded Spark test cases (Parquet aggregate pushdown, UDAF, streaming/real-time streaming, and the valid Variant binary case).
Changes:
- Disable
GlutenExplainSuitein Spark 4.0 and 4.1 Velox UT settings with an explicit reason. - Remove exclusions to re-enable Parquet aggregate pushdown and UDAF-related test cases.
- Remove exclusions to re-enable streaming and real-time streaming test cases; re-enable the valid Variant binary case while keeping the invalid one excluded.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gluten-ut/spark40/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Disables GlutenExplainSuite and removes multiple per-test exclusions to re-enable previously skipped cases for Spark 4.0 Velox UTs. |
| gluten-ut/spark41/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala | Disables GlutenExplainSuite and removes multiple per-test exclusions to re-enable previously skipped cases for Spark 4.1 Velox UTs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+876
to
+878
| disableSuite[GlutenExplainSuite]( | ||
| "Validates Spark-specific physical plan and JVM codegen output that does not apply to " + | ||
| "Gluten's native execution plan") |
Comment on lines
+896
to
+898
| disableSuite[GlutenExplainSuite]( | ||
| "Validates Spark-specific physical plan and JVM codegen output that does not apply to " + | ||
| "Gluten's native execution plan") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables GlutenExplainSuite because it validates Spark-specific physical plans and JVM codegen output that do not apply to Gluten’s native execution plan.
Enables previously excluded Parquet aggregate pushdown, UDAF, streaming, and real-time streaming tests.
Enables the valid Variant binary test while keeping the invalid case excluded due to the Velox Parquet writer’s nullability limitation.
Related issue: #11550