Add WebLogic 14.x and 15.x server support#9414
Closed
ganigurgah wants to merge 2 commits into
Closed
Conversation
mbien
added
Java EE/Jakarta EE
mbien
reviewed
May 29, 2026
mbien
added
the
ci:dev-build
Fixes apache#6109 **Issue** NetBeans WebLogic plugin did not recognize WebLogic 14.x and 15.x installations as supported versions and did not offer them as deployment targets for Jakarta EE projects. **Fix** - WebLogicLayout.isSupportedVersion(): replaced hardcoded version whitelist with isAboveOrEqual("9.0.0.0") so future versions are supported without code changes - WLDeploymentFactory: added VERSION_1411 and VERSION_1511 constants - WLJ2eePlatformFactory: added Java EE 8, Jakarta EE 8, Jakarta EE 9, 9.1, 10 and 11 profile support for WebLogic 14+ and 15+; added JDK 11 and 17 as supported Java versions for WebLogic 14+ and 15+ - BaseDescriptorModel: added VERSION_14_1_1 constant - WebLogicLayoutTest: added test coverage for versions 14.x and 15.x - Switched the module to javac.release=21 (NetBeans project baseline) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ganigurgah
force-pushed
the
weblogic-14c-support
branch
from
6605323 to
6446239
Compare
Author
|
Thanks for the review @mbien Addressed all three:
|
Member
|
@ganigurgah sorry for the delay, I wasn't available for various reasons. Will try to get to this soon. |
mbien
reviewed
Jun 16, 2026
mbien
left a comment
mbien
left a comment
Member
There was a problem hiding this comment.
we don't really have guidelines for LLM assisted contributions yet, I started a thread at https://lists.apache.org/thread/qhr3mfxg5wsv89d80nxzdd63ldjth07p to clear things up.
btw please don't add merge commits to the PR branch. It is ok to rebase if you would like to refresh, esp when the changeset is smaller. (we will merge the PR without rebase on integration)
running pull --rebase will also remove the merge commit again
git pull --rebase --autostash https://github.com/apache/netbeans.git master
and force push as before
Comment on lines
+133
to
+135
| private static final Version JDK11_SUPPORTED_SERVER_VERSION = Version.fromJsr277NotationWithFallback("14.1.1"); // NOI18N | ||
|
|
||
| private static final Version JDK17_SUPPORTED_SERVER_VERSION = Version.fromJsr277NotationWithFallback("15.1.1"); // NOI18N |
Member
There was a problem hiding this comment.
seems to be correct
- https://docs.oracle.com/en/middleware/standalone/weblogic-server/14.1.1.0/notes/whatsnew.html#GUID-960100E8-DFC1-49E5-8CED-1EC1D883A42F
- https://docs.oracle.com/en/middleware/standalone/weblogic-server/15.1.1/notes/whatsnew.html#GUID-B6E42F6B-3C3C-4332-A064-DE14CD1A7E5C
but the versioning scheme is a bit wild, e.g it seems like 14.1.2 also supports 17 and 21
might not be super important though, worst case is that JDK 11 will show up on a lower version in the combo box I suppose.
Comment on lines
+48
to
+49
|
|
||
| protected static final Version VERSION_14_1_1 = Version.fromJsr277NotationWithFallback("14.1.1"); // NOI18N |
Member
There was a problem hiding this comment.
this doesn't appear to be used.
this indicates that either:
- the three generate methods in the model classes
EjbJarModel,EarApplicationModelandWebApplicationModelneed to be updated - or update is not needed and the constant can be removed if the emitted code is OK for the version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6109
Issue
NetBeans WebLogic plugin did not recognize WebLogic 14.x and 15.x installations as supported versions and did not offer them as deployment targets for Jakarta EE projects.
Fix