games/NXDoom: Fix build warnings#3577
Merged
Merged
Conversation
This commit resolves all of the build warnings that were preventing NXDoom from compiling in CI runs. Signed-off-by: Matteo Golin <matteo.golin@gmail.com>
linguini1
requested review from
acassis,
cederom,
davids5,
jerpelea,
michallenc,
raiden00pl and
xiaoxiang781216
cederom
approved these changes
Jul 1, 2026
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @linguini1 :-)
Contributor
|
@linguini1 please rebase to fix this error: |
Contributor
|
CI Linux Arm14 failed, also in other PR, not restarting here as it seems random failure, lets see the other PRs first to save CI resrources :-) |
acassis
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit resolves all of the build warnings that were preventing NXDoom from compiling in CI runs.
Fixes the issues in apache/nuttx#19239.
Impact
NXDoom can build in CI! Only this application is affected.
Removes packed struct optimization from state lookup table and extends a few
buffers used by snprintf.
Testing
Ran CI build manually to verify pass: https://github.com/linguini1/manual-nuttx-ci/actions/runs/28522157686/job/84549082064
Also re-ran DOOM on sim:nxdoom and it works.