interpreters/berry: Fix Wshadow build errors#3578
Merged
Merged
Conversation
The pinned Berry source emits -Wshadow diagnostics in a couple of files. NuttX CI passes -Werror, so sim:berry fails when those third-party warnings are promoted to errors.\n\nAdd -Wno-shadow to Berry-specific compiler flags in both Make and CMake paths, keeping the local source patch limited to the NuttX port changes. Signed-off-by: Frederick Blais <fred_blais5@hotmail.com>
0409fca to
7fcaebf
Compare
Contributor
Author
|
Updated to use I kept the flag scoped to the Berry build only:
I reran the targeted failing config in the Apache Linux CI container against the NuttX PR head plus this apps commit: Both Make and CMake/Ninja |
linguini1
approved these changes
Jul 1, 2026
Contributor
|
CI Linux Arm14 failed, restarted, let make sure it pass this time :-) |
cederom
approved these changes
Jul 1, 2026
jerpelea
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the current
sim:berryLinux CI failure seen fromapache/nuttx#19224after the CRLF patch fix was merged.The pinned Berry source compiles with two
-Wshadowdiagnostics in:src/be_introspectlib.csrc/be_module.cNuttX CI builds
sim:berrywith-Werror, so those diagnostics fail the build. I added a second local Berry patch that only renames the shadowing local variables, without changing behavior, and apply it in both the Make and CMake fetch paths.Verification
I verified the patch applies cleanly to the exact pinned Berry ZIP payload after the existing NuttX patch.
I also ran the targeted failing config in the Apache Linux CI container against
apache/nuttx#19224head plus this apps commit:Result:
sim:berryMake build passed.I also tested the CMake/Ninja path:
Result:
sim:berryCMake/Ninja build passed.Local checks: