[GH-3587]: Fix parquet.thrift.string.size.limit validation#3588
Open
divjotarora wants to merge 1 commit into
Open
[GH-3587]: Fix parquet.thrift.string.size.limit validation#3588divjotarora wants to merge 1 commit into
divjotarora wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR fixes a small bug in
parquet.thrift.string.size.limitvalidation here. If this config is explicitly set to -1, the code indicates that the default max message size should be used, but also throws an exception.What changes are included in this PR?
If
parquet.thrift.string.size.limit == -1, use the default value and do not fail validation.Are these changes tested?
Yes, there are new regression tests added to
TestParquetFileReaderMaxMessageSize.Are there any user-facing changes?
No.
Closes #GH-3587