Remove duplicated image name in image JSON output#1655
Merged
Conversation
jglogan
approved these changes
Jun 5, 2026
realrajaryan
approved these changes
Jun 5, 2026
Contributor
|
@katiewasnothere this one needs test updates to account for the change. |
jglogan
requested changes
Jun 5, 2026
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
CLI tests related to the change are failing.
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
katiewasnothere
force-pushed
the
remove_dup_name_image
branch
from
678d2de to
5ba25a8
Compare
Code Coverage
|
jglogan
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
#1652 rearranged the JSON output for image resources and included a duplicate "name" field. After further discussion, we've decided to remove the duplicate field.
Testing