Test send_error_with_context closes span on raise#269
Merged
Conversation
Port the regression test from appsignal-nodejs#1449. Unlike the Node.js helper, which had to be fixed to end the span in a finally block, the Python helper already closes the error span when the `with` block raises, since it builds on OpenTelemetry's start_as_current_span context manager. This locks in that behaviour.
|
Hi @unflxw, We've found some issues with your Pull Request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the regression test from appsignal/appsignal-nodejs#1449. Unlike the
Node.js helper, which had to be fixed to end the span in a finally
block, the Python helper already closes the error span when the
withblock raises, since it builds on OpenTelemetry'sstart_as_current_span context manager. This locks in that behaviour.