Populate ProblemDetails.Status on error responses#254
Open
inghamc wants to merge 1 commit into
Open
Conversation
ProblemDetails bodies for several statuses were returned without the Status field set, so the JSON body's `status` was null even though the HTTP status code was correct. Set it consistently across the Minimal API and MVC conversion paths (RFC 7807 section 3.1). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #253.
ProblemDetailsbodies were returned withoutStatusset, so the body'sstatuswasnulleven though the HTTP status code was correct (and it was applied inconsistently — see #253 for the audit table). This populates it across both conversion paths:MinimalApiResultExtensions): addedStatusto the 422 / 404 / 409 builders (the three that omitted it).ActionResultExtensions): setProblemDetails.Statusfrom the resolved status code inToActionResult, so it stays correct even when a consumer remaps status codes viaResultStatusMap, rather than hardcoding it in each builder.Non-breaking — this only adds the
statusfield to the response body; HTTP status codes are unchanged. Tested on net6.0 / net7.0 / net8.0.🤖 Generated with Claude Code