Skip to content

feat(format): enumerate tracked files via git ls-files in --scope=all #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregmagolan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(format): enumerate tracked files via git ls-files in --scope=all #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions .buildkite/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,13 @@ steps:
- exit_status: 78 # unhealthy signal from .buildkite/hooks/pre-command
limit: 1
command: |
ASPECT_DEBUG=1 aspect buildifier --task:name buildifier-bk-debug
aspect buildifier --task:name buildifier-bk
ASPECT_DEBUG=1 aspect buildifier --task-key buildifier-bk-debug
aspect buildifier --task-key buildifier-bk
ASPECT_DEBUG=1 aspect buildifier --scope=tracked --task-key buildifier-bk-tracked-debug
aspect buildifier --scope=tracked --task-key buildifier-bk-tracked
ASPECT_DEBUG=1 aspect buildifier --scope=all --task-key buildifier-bk-all-debug
aspect buildifier --scope=all --task-key buildifier-bk-all

- key: format-task
label: ":aspect: Format Task"
depends_on:
Expand All @@ -252,8 +257,13 @@ steps:
# Starlark patterns are handled by buildifier-task; ignore them here so
# the two steps don't do duplicate work.
command: |
ASPECT_DEBUG=1 aspect format --task:name format-bk-debug
aspect format --task:name format-bk
ASPECT_DEBUG=1 aspect format --task-key format-bk-debug
aspect format --task-key format-bk
ASPECT_DEBUG=1 aspect format --scope=tracked --task-key format-bk-tracked-debug
aspect format --scope=tracked --task-key format-bk-tracked
ASPECT_DEBUG=1 aspect format --scope=all --task-key format-bk-all-debug
aspect format --scope=all --task-key format-bk-all

- key: gazelle-task
label: ":aspect: Gazelle Task"
depends_on:
Expand Down
30 changes: 28 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,20 @@ jobs:
command: ASPECT_DEBUG=1 aspect buildifier --task:name buildifier-cci-debug
- run:
name: Buildifier Task
command: aspect buildifier --task:name buildifier-cci
command: aspect buildifier --task-key buildifier-cci
- run:
name: Buildifier Task (scope=tracked, ASPECT_DEBUG=1)
command: ASPECT_DEBUG=1 aspect buildifier --scope=tracked --task-key buildifier-cci-tracked-debug
- run:
name: Buildifier Task (scope=tracked)
command: aspect buildifier --scope=tracked --task-key buildifier-cci-tracked
- run:
name: Buildifier Task (scope=all, ASPECT_DEBUG=1)
command: ASPECT_DEBUG=1 aspect buildifier --scope=all --task-key buildifier-cci-all-debug
- run:
name: Buildifier Task (scope=all)
command: aspect buildifier --scope=all --task-key buildifier-cci-all

format-task:
machine: true
resource_class: aspect-build/aspect-default
Expand All @@ -132,7 +145,20 @@ jobs:
command: ASPECT_DEBUG=1 aspect format --task:name format-cci-debug
- run:
name: Format Task
command: aspect format --task:name format-cci
command: aspect format --task-key format-cci
- run:
name: Format Task (scope=tracked, ASPECT_DEBUG=1)
command: ASPECT_DEBUG=1 aspect format --scope=tracked --task-key format-cci-tracked-debug
- run:
name: Format Task (scope=tracked)
command: aspect format --scope=tracked --task-key format-cci-tracked
- run:
name: Format Task (scope=all, ASPECT_DEBUG=1)
command: ASPECT_DEBUG=1 aspect format --scope=all --task-key format-cci-all-debug
- run:
name: Format Task (scope=all)
command: aspect format --scope=all --task-key format-cci-all

gazelle-task:
machine: true
resource_class: aspect-build/aspect-default
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/ci-workflows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ jobs:
aspect-api-token: ${{ secrets.ASPECT_API_TOKEN }}
- name: Buildifier Task
run: aspect buildifier --task:name buildifier-gha
- name: Buildifier Task (scope=tracked)
run: aspect buildifier --scope=tracked --task:name buildifier-gha-tracked
- name: Buildifier Task (scope=all)
run: aspect buildifier --scope=all --task:name buildifier-gha-all
buildifier-debug-task:
runs-on: ubuntu-latest
needs: [pre-build]
Expand All @@ -144,6 +148,10 @@ jobs:
aspect-api-token: ${{ secrets.ASPECT_API_TOKEN }}
- name: Format Task
run: bazel format --task:name format-gha
- name: Format Task (scope=tracked)
run: bazel format --scope=tracked --task:name format-gha-tracked
- name: Format Task (scope=all)
run: bazel format --scope=all --task:name format-gha-all
format-debug-task:
runs-on: ubuntu-latest
needs: [pre-build]
Expand Down
16 changes: 12 additions & 4 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,12 @@ buildifier-task:
- aspect-default
script:
- .aspect/bootstrap.sh
- ASPECT_DEBUG=1 aspect buildifier --task:name buildifier-gl-debug
- aspect buildifier --task:name buildifier-gl
- ASPECT_DEBUG=1 aspect buildifier --task-key buildifier-gl-debug
- aspect buildifier --task-key buildifier-gl
- ASPECT_DEBUG=1 aspect buildifier --scope=tracked --task-key buildifier-gl-tracked-debug
- aspect buildifier --scope=tracked --task-key buildifier-gl-tracked
- ASPECT_DEBUG=1 aspect buildifier --scope=all --task-key buildifier-gl-all-debug
- aspect buildifier --scope=all --task-key buildifier-gl-all
format-task:
stage: CI
needs: [pre-build]
Expand All @@ -88,8 +92,12 @@ format-task:
# two steps don't do duplicate work.
script:
- .aspect/bootstrap.sh
- ASPECT_DEBUG=1 aspect format --task:name format-gl-debug
- aspect format --task:name format-gl
- ASPECT_DEBUG=1 aspect format --task-key format-gl-debug
- aspect format --task-key format-gl
- ASPECT_DEBUG=1 aspect format --scope=tracked --task-key format-gl-tracked-debug
- aspect format --scope=tracked --task-key format-gl-tracked
- ASPECT_DEBUG=1 aspect format --scope=all --task-key format-gl-all-debug
- aspect format --scope=all --task-key format-gl-all
gazelle-task:
stage: CI
needs: [pre-build]
Expand Down
Loading
Loading