Skip to content

feat(axl): add current_dir for query/info#1263

Open
cristifalcas wants to merge 1 commit into
mainfrom
cf/ctx-bazel-run
Open

feat(axl): add current_dir for query/info#1263
cristifalcas wants to merge 1 commit into
mainfrom
cf/ctx-bazel-run

Conversation

@cristifalcas

@cristifalcas cristifalcas commented Jun 22, 2026

Copy link
Copy Markdown

Align query / info with build / test by giving them a current_dir argument.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@aspect-workflows

aspect-workflows Bot commented Jun 22, 2026

Copy link
Copy Markdown

✨ Aspect Workflows Tasks

📅 Fri Jun 26 21:32:38 UTC 2026

🔄 9 in progress tasks

  • 🔄 buildifier-gha-debug [buildifier] · ⏱ 14.2s · 🐙 GitHub Actions · ☑️ Check
    💬 Building formatter... (@buildifier_prebuilt//buildifier)
  • 🔄 buildifier-gha [buildifier] · ⏱ 6.8s · 🐙 GitHub Actions · ☑️ Check
    💬 Building formatter... (@buildifier_prebuilt//buildifier)
  • 🔄 format-gha-debug [format] · ⏱ 14.8s · 🐙 GitHub Actions · ☑️ Check
    💬 Building formatter... (//tools/format)
  • 🔄 format-format-repeat-task [format] · ⏱ 7.4s · 🐙 GitHub Actions · ☑️ Check
    💬 Building formatter... (//tools/format)
  • 🔄 format-gha [format] · ⏱ 6.9s · 🐙 GitHub Actions · ☑️ Check
    💬 Building formatter... (//tools/format)
  • 🔄 gazelle-gha-debug [gazelle] · ⏱ 6.1s · 🐙 GitHub Actions · ☑️ Check
    💬 Building gazelle... (//tools/gazelle:gazelle)
  • 🔄 gazelle-from-source-gha-debug [gazelle] · ⏱ 7s · 🐙 GitHub Actions · ☑️ Check
    💬 Building gazelle... (//tools/gazelle:gazelle_from_source)
  • 🔄 gazelle-from-source-gha [gazelle] · ⏱ 41.3s · 🐙 GitHub Actions · ☑️ Check
    💬 Building gazelle... (//tools/gazelle:gazelle_from_source)
  • 🔄 gazelle-gha [gazelle] · ⏱ 7.9s · 🐙 GitHub Actions · ☑️ Check
    💬 Building gazelle... (//tools/gazelle:gazelle)

⚠️ 2 flagged tasks

  • ⚠️ delivery-gha-debug [delivery] · ⏱ 1m 21s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Delivery complete (1 delivered · 2 warn · 3 skipped)
  • ⚠️ delivery-gha [delivery] · ⏱ 1m 10s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Delivery complete (1 delivered · 2 warn · 3 skipped)

✅ 15 successful tasks

  • ✅ axl-smoke-gha-bootstrap [build] · ⏱ 1m · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel build complete (1 built)
  • ✅ run-axl-smoke [run] · ⏱ 35.6s · 🐙 GitHub Actions · ☑️ Check
    💬 Ran //examples/deliverable:py_deliverable
  • ✅ run-axl-smoke-2 [run] · ⏱ 29.5s · 🐙 GitHub Actions · ☑️ Check
    💬 Ran //examples/deliverable:sh_deliverable
  • ✅ axl-tests-gha-bootstrap [build] · ⏱ 1m 36s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel build complete (1 built)
  • ✅ build-gha-debug [build] · ⏱ 8m 28s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel build complete (166 built)
  • ✅ build-gha [build] · ⏱ 8m 18s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel build complete (166 built)
  • ✅ build-gha-ephemeral [build] · ⏱ 1m 22s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel build complete (9 built)
  • ✅ init-shell [build] · ⏱ 41.6s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel build complete (10 built)
  • ✅ lint-gha-debug [lint] · ⏱ 1m 13s · 🐙 GitHub Actions · ☑️ Check
    💬 Lint complete (clean)
  • ✅ lint-gha [lint] · ⏱ 1m 2s · 🐙 GitHub Actions · ☑️ Check
    💬 Lint complete (clean)
  • ✅ test-gha-debug [test] · ⏱ 8m 48s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (26/26 passed · 23 cached)
  • ✅ test-gha-coverage [test] · ⏱ 44.5s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test-gha-target-pattern-file [test] · ⏱ 54.5s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed · 1 cached)
  • ✅ test-gha [test] · ⏱ 8m 48s · ✨ Aspect · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (26/26 passed · 25 cached)
  • ✅ test-gha-ephemeral [test] · ⏱ 1m 5s · 🐙 GitHub Actions · ☑️ Check
    💬 Bazel test complete (1/1 passed)

🔁 Reproduce

⚠️ delivery (delivery-gha-debug · delivery-gha)

# --mode=always --track-state=false for off-runner with no state backend.
aspect delivery \
  --commit-sha=7b4c60636c16a670b6b06042558d7313e24cea18 \
  --mode=always \
  --track-state=false \
  --dry-run=true

Install aspect: aspect.build/docs/cli/install


⏱ Last updated Fri Jun 26 21:44:19 UTC 2026 · 📊 GitHub API quota 1,759/15,000 (12% used, resets in 27m, throttle 2×)
🚀 Powered by Aspect CLI (v0.0.0-dev)  |  Aspect Build · X · LinkedIn · YouTube

@cristifalcas cristifalcas marked this pull request as ready for review June 22, 2026 19:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c325bcd6f7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread crates/axl-runtime/src/engine/bazel/mod.rs Outdated
@thesayyn

Copy link
Copy Markdown
Member

We don't want a ctx.bazel.run(), see existing run.axl implementation how it works. As for current_dir, we probably want a unified api for it, something like ctx.bazel.build(directory=) | ctx.bazel.test(directory=)

@rafikk

rafikk commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

We don't want a ctx.bazel.run(), see existing run.axl implementation how it works.

As a user, the lack of a ctx.bazel.run primitive is one of the sharpest edges in using aspect-cli today. Running a target requires excessive ceremony which obscures the actual logic in custom task implementations. I would love to see it included in the API.

@cristifalcas cristifalcas changed the title feat(axl): add ctx.bazel.run and current_dir for query/info feat(axl): add current_dir for query/info Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants