feat: Add biome linter/formatter#887
Open
SiarheiFedartsou wants to merge 11 commits into
Open
Conversation
|
|
|
|
| // If it's already in SARIF format, normalize paths before returning it. | ||
| if regex.Match([]byte(report)) { | ||
| return report, nil | ||
| return normalizeSarifUris(label, report) |
Author
There was a problem hiding this comment.
It seems it always was the issue that paths there are not normalized...
SiarheiFedartsou
changed the title
SiarheiFedartsou
requested review from
JesseTatasciore and
jbedard
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Issue: #538
I was mainly following ESLint/Prettier as an example.
NOTE: I am very new to this project, so I was heavily relying on AI to help me with this PR, I hope it is acceptable.
Test plan
New tests added.