fix(uv): restore Bazel 7 compatibility by replacing set() with a bazel_features-aware compat shim#1070
Draft
xangcastle wants to merge 1 commit into
Draft
fix(uv): restore Bazel 7 compatibility by replacing set() with a bazel_features-aware compat shim#1070xangcastle wants to merge 1 commit into
xangcastle wants to merge 1 commit into
Conversation
…zel 7 compatibility
✨ Aspect Workflows Tasks📅 Mon Jun 1 17:14:30 UTC 2026 ✅ 7 successful tasks
⏱ Last updated Mon Jun 1 17:44:44 UTC 2026 · 📊 GitHub API quota 1,507/15,000 (10% used, resets in 36m, throttle 3×) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users on Bazel 7 hit a load-time error in
graph_utils.bzlanduv_project/repository.bzlbecauseset()is a Starlark built-inthat was only introduced in Bazel 8. Any workspace still on Bazel 7
fails immediately with:
Solution
Adds
uv/private/compat.bzl, a thin shim that usesbazel_features(already a project dependency) to select the right implementation at
repository evaluation time:
set()constructor — O(1)membership, zero overhead.
standard Starlark idiom and fully compatible.
Iteration (
for x in s) and membership (x in s) work identically onboth a native set and a dict, so call-site ergonomics are unchanged.
Affected files
uv/private/compat.bzl— new shim (new_set / set_add)uv/private/extension/graph_utils.bzl— was line 25uv/private/uv_project/repository.bzl— was line 93Changes are visible to end-users: no
Test plan