fix: handle uv extra== conflict markers in uv_project select() generation#1104
Draft
xangcastle wants to merge 1 commit into
Draft
fix: handle uv extra== conflict markers in uv_project select() generation#1104xangcastle wants to merge 1 commit into
xangcastle wants to merge 1 commit into
Conversation
✨ Aspect Workflows Tasks📅 Thu Jun 11 13:15:21 UTC 2026 ❌ 2 failed tasks
✅ 5 successful tasks
🔁 Reproduce❌ test (test-e2e-bazel-8 · test-e2e-bazel-9)Install ⏱ Last updated Thu Jun 11 13:52:26 UTC 2026 · 📊 GitHub API quota 715/15,000 (5% used, resets in 19m, throttle 3×) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a [dependency-groups] entry acts as a shared group referencing a package that has conflicting versions across other groups, uv encodes the ambiguity in the lock file using synthetic extra == 'group-24-...' markers. These markers are uv-internal routing hints, not real PEP 508 environment markers, so they can't be evaluated as Bazel config_setting targets at build time.
The old code passed them straight into _conditionalize, which tried to create a decide_marker target for each one, causing hub analysis to fail entirely whenever a project used this lock file pattern.
The fix detects these pseudo-markers via _has_extra_marker and treats them as unconditional (//conditions:default), which is correct because the per-venv select() layer already handles group routing; the extra markers are just uv's way of annotating which version belongs to which conflict group in the lock file.
Changes are visible to end-users: no
Test plan