fix(py): avoid dirname in console scripts#1212
Open
tamird wants to merge 1 commit into
Open
Conversation
Resolve the sibling venv interpreter with POSIX shell parameter expansion. Generated console scripts then need only the venv bin directory on PATH and do not depend on an ambient dirname executable.
py_binary startup benchmark
sys.path quality
✅ No regression detected (PR is +1.9% vs HEAD main) |
jbedard
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated console-script wrappers resolve their sibling interpreter by running dirname. A caller can find the wrapper through a PATH containing only the venv bin directory, but the wrapper cannot find dirname, expands its interpreter path to /python, and fails before the entry point runs.
Resolve the sibling interpreter with POSIX shell parameter expansion. The wrapper stays relocatable and keeps the existing dotted-entry-point dispatch without an ambient tool dependency.
The console-script runtime test now invokes a generated cowsay wrapper with PATH limited to its venv bin directory. It fails on the previous wrapper with dirname not found and /python missing, and passes with this change.