Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Add support for decorators#187

Open
winstliu wants to merge 7 commits into
masterfrom
wl-decorators
Open

Add support for decorators#187
winstliu wants to merge 7 commits into
masterfrom
wl-decorators

Conversation

@winstliu

@winstliu winstliu commented Aug 2, 2015

Copy link
Copy Markdown
Contributor

Closes #163

/cc @mehcode

@mehcode

mehcode commented Aug 7, 2015

Copy link
Copy Markdown

Looks awesome @50Wliu

@silvenon

silvenon commented Mar 4, 2016

Copy link
Copy Markdown

👍

# Conflicts:
#	grammars/javascript.cson
@winstliu

Copy link
Copy Markdown
Contributor Author

Updated for the ES2016 syntax based on examples and terminology from https://medium.com/google-developers/exploring-es7-decorators-76ecb65fb841#.blq52cu0r.

@winstliu

Copy link
Copy Markdown
Contributor Author

Marking as blocked until the proposal is standardized.

@icecream17

Copy link
Copy Markdown
Contributor

the proposal is standardized now

@winstliu

Copy link
Copy Markdown
Contributor Author

Thanks @icecream17, I'll see if there's any updates I need to handle from the standardized proposal and also try to resolve the merge conflicts if they're not too nasty.

@winstliu

Copy link
Copy Markdown
Contributor Author

@icecream17 where are you seeing that the proposal is standardized? It still appears to be in Stage 2, from what I can find: https://github.com/tc39/proposals/blob/2c2ad83616b845af6c8000e367140932dd4f1c88/README.md#stage-2

@icecream17

Copy link
Copy Markdown
Contributor

Oh what - I thought it was 2017. Hmm, must've got confused. Oops. Sorry about that.

Yeah you're right, still not standardized yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add highlighting for decorators / annotations

4 participants