refactor(coredaos): migrate away from atomone's x/gov wrapper#353
Merged
Conversation
tbruyelle
approved these changes
Jun 29, 2026
tbruyelle
left a comment
tbruyelle
left a comment
Collaborator
There was a problem hiding this comment.
Having to deal direclty with the gov keeper fields like keeper.Proposals is a bit annoying as it forbids the usage of a local interface. But that's out of the scope of this PR.
LGTM
Collaborator
Author
nothing to do here unfortunately because of collections, using the keeper directly is unavoidable. The methods the previous interface was using are simply gone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on atomone
x/govwrapper fromx/coredaosin favor of using the atomone-sdkx/gov.This work alongside atomone-hub/atomone-sdk#106 is a prerequisite for a future-coming PR that does some further cleaning/refactoring.