Cleanup: fix setup docs and make the smoke test portable#2
Open
shaq-authlete wants to merge 3 commits into
Open
Cleanup: fix setup docs and make the smoke test portable#2shaq-authlete wants to merge 3 commits into
shaq-authlete wants to merge 3 commits into
Conversation
- Add generation command for BETTER_AUTH_SECRET - Add a jose one-liner to generate the ES256 signing JWKS - Document the AS_JWKS_URI default Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- npm to pnpm; correct migrate command (better-auth, not @better-auth/cli) with the inline env vars it needs - Add Prerequisites section pointing at the AS README provisioning - Track data/ via .gitkeep so the default SQLITE_DB_PATH resolves on a fresh clone - Expand the smoke test section: what it covers and what it bypasses - Unify naming to Interaction Protocol - Ignore CLAUDE.md (local agent notes) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- RP_CLIENT_ID is now a required env var instead of a hardcoded client id; RP_REDIRECT_URI is overridable - Fail with non-zero exit on state mismatch, wrong userinfo claims, inactive introspection, failed revocation, and a revoked token that is still accepted (all previously printed but never failed) - Document why the introspection Basic creds are placeholders Verified: full run prints E2E COMPLETE with exit 0; missing RP_CLIENT_ID exits 1 with a clear error. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of making this repo customer-presentable. Docs, config hygiene, and smoke test fixes. No changes to the app itself.
Changes
pnpm exec better-auth migrate -ywith the inline env vars it needs), added a Prerequisites section, expanded the smoke test sectionVerification
Full run prints E2E COMPLETE with exit 0 against a running AS and auth-ui. Missing RP_CLIENT_ID exits 1 with a clear error.
Further cleanup (dependency hygiene, comment fixes) is planned in a follow-up, tracked in the task notes.
🤖 Generated with Claude Code