feat: expose optional-MFA-with-skip, passkey-MFA, and is_mfa_enforced fields#45
Closed
lakhansamani wants to merge 8 commits into
Closed
feat: expose optional-MFA-with-skip, passkey-MFA, and is_mfa_enforced fields#45lakhansamani wants to merge 8 commits into
lakhansamani wants to merge 8 commits into
Conversation
Nested worktree under authorizer-js/ let ESLint cascade into the parent repo's .eslintrc.js, resolving @typescript-eslint/eslint-plugin from two node_modules trees and failing with an ambiguous-plugin error.
…aSetup() Bump 3.4.0-rc.0. skipMfaSetup mirrors deactivateAccount's authenticated dispatch shape (headers passthrough), not resendOtp's unauthenticated one, since it dismisses the current user's own MFA setup prompt.
4 tasks
Contributor
Author
|
Superseded by an upcoming PR built against authorizer#686 (MFA behavior redesign — withheld-token first-time setup, reworked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SDK support for the backend's MFA work (see authorizerdev/authorizer#685):
skipMfaSetup(),should_offer_mfa_setup,has_skipped_mfa_setup_at— optional MFA setup with skip.should_offer_webauthn_mfa_verifyonAuthResponse— passkey as a second MFA factor.loginWithPasskey(email)(already shipped) is reused as-is for the verify step; no new SDK methods needed.is_mfa_enforcedonMeta— letsauthorizer-reacthide the primary passkey-login button when the org enforces MFA.querySynctest that asserts everyMeta/AuthResponseinterface field is actually selected in the corresponding GraphQL query string (and vice versa) — added after two of the fields above shipped with a type but no matching query selection, silently making them dead on arrival. Type-checking alone can't catch this class of bug since the interface and the query string are independent.Version: 3.3.0-rc.1 → 3.6.0-rc.0.
Test plan
npm run buildclean (CJS/ESM/DTS)__test__/querySync.test.ts— confirmed it catches drift in both directions by deliberately breaking sync and watching it fail, then restoringnpm run testsuite — all suites pass except one pre-existing, unrelated failure inindex.test.ts(testcontainers-based integration tests), confirmed present on the base commit before any of this work via a side-by-side worktree comparison — not a regression from this PR