fix(states-editor): make 'merge down to provinces' checkbox visible#6
Merged
Merged
Conversation
FMG hides every raw checkbox via 'input[type=checkbox]:not(.native){display:none}'.
The new merge-down checkbox had no class, so only its label text rendered and
the control was unusable. Add class="native" (the convention used elsewhere,
e.g. burg-group-editor) so it shows as a normal checkbox. Bump the states-editor
dynamic-import cache-bust token to 1.122.13 so clients re-fetch.
✅ Deploy Preview for bazgaars-fmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Merge down to provincesoption (PR #4) shipped its descriptive text but no usable checkbox — only the label rendered, so the feature couldn't be toggled.Cause
public/index.csshides every raw checkbox:Visible checkboxes must opt in via
.native(a normal checkbox) or the.checkbox+.checkbox-labelpattern. The new control had no class, so it wasdisplay:nonewhile its<span>text still showed.Fix
class="native"to the checkbox (the convention used elsewhere, e.g.burg-group-editor.js).states-editor.jsdynamic-import cache-bust token?v=1.122.12→?v=1.122.13so clients re-fetch the updated file.