fix(states-editor): painter pagination, merge sort, visible province demotion#8
Merged
Merged
Conversation
…vince demotion Addresses tester feedback on the state merge + demote-to-province workflow: - State painter (manual assignment) only let you select states on the first page: the editor list is paginated at 200 and the pager is hidden in paint mode, so any state beyond page 1 had no clickable row. Render the full set while customization === 2 so every state is selectable. - Merge dialog listed states by state id regardless of the editor's active sort. Apply sortDataByActiveHeader so the list mirrors the column the user sorted by (culture, name, etc.). - "Merge down to provinces" could look like a plain merge: the new province was only drawn if the provinces layer happened to be on. Force the provinces layer on (matching how states force their own layer) so the demoted territory is always visible as a province. - Demoting a state now keeps its government form: a merged Duchy becomes "<name> Duchy" instead of "<name> Province" (falls back to "Province" when the state has no form name). Bump states-editor cache-bust token to 1.122.15.
✅ Deploy Preview for bazgaars-fmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses tester feedback on the state merge + demote-to-province workflow.
Changes
State painter couldn't select states past page 1 (e.g. Kingdom of Levarois). The editor list is paginated at 200 and the pager is hidden in paint mode, so any state beyond the first page had no clickable row to select as the brush target. Now renders the full state set while in manual-assignment mode (
customization === 2).Merge dialog ignored the editor's sort. It always listed states by state id. Now applies
sortDataByActiveHeader, so the merge list mirrors whatever column the editor is sorted by (culture, name, etc.)."Merge down to provinces" could look like a plain merge. Root cause was visual: the new province was only drawn if the provinces layer happened to be on. States force their own layer on; provinces didn't. Now forces the provinces layer on when demoting, so the demoted territory is always visible as a province. (This also covers "former territory should become a new province" — the province existed but was invisible.)
Demoting a state now keeps its government form. A merged Duchy becomes
<name> Duchyinstead of<name> Province(falls back to "Province" when the state has no form name).Bumps the states-editor cache-bust token to
1.122.15.Verification
node --checkpasses on both touched files.