fix: preserve empty list/dict values in serialize() when fields specified (#146)#154
Open
rtmalikian wants to merge 1 commit into
Open
fix: preserve empty list/dict values in serialize() when fields specified (#146)#154rtmalikian wants to merge 1 commit into
rtmalikian wants to merge 1 commit into
Conversation
…fied
When save(update_fields=[...]) is used with a field set to [] or {},
clean_empty_values() strips it from the serialized output, causing
a KeyError when save() tries to extract the specified fields.
Fix by adding a parameter to serialize() that restores
empty values for explicitly requested fields after cleaning.
Fixes beda-software#146
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression in v2.0.6 where
save(update_fields=[...])fails withKeyErrorwhen one of the specified fields has an empty list ([]) or empty dict ({}) value.Root cause:
serialize()always callsclean_empty_values(), which strips empty lists and dicts from the output. Whensave()then tries to extract the specified fields withdata = {key: data[key] for key in fields}, the missing key raisesKeyError.Fix:
serialize()now accepts an optionalfieldsparameter. When provided, empty values for those specific keys are preserved after cleaning. This ensures that users can intentionally set fields to[]or{}to clear them via a partial update, without breaking the serialization pipeline for other fields.Changes
fhirpy/base/resource.pyfieldsparameter toserialize(); restore empty values for specified fields afterclean_empty_values()fhirpy/base/lib_async.pyfieldstoserialize()inAsyncClient.save()fhirpy/base/lib_sync.pyfieldstoserialize()inSyncClient.save()tests/test_utils.pyVerification
Reproduction (before fix)
After fix, the empty list is preserved for the specified field and the save succeeds.
Fixes #146
About the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from mimo-2.5-pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.