Remove sequence as a distinct element + allow decisions/subtree after action#114
Open
MegaIng wants to merge 6 commits into
Open
Remove sequence as a distinct element + allow decisions/subtree after action#114MegaIng wants to merge 6 commits into
MegaIng wants to merge 6 commits into
Conversation
MegaIng
force-pushed
the
feature/remove_sequences
branch
from
c03a056 to
54fad4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also add a comprehensive test suite
Summary
This PR changes the implementation of action sequences from a distinct TreeElement to instead have actions be a chain where they each refer to the tree element that comes after them. This allows for an easy syntax extension where Actions can come before decisions or invocations of subtrees (see #66). The code here is generally simplified quite a bit without any changes in the edge cases I am aware of.
The display in the visualization is changed slightly. Now it's a chain of rectangular boxes which may also have a decision as a child.
To verify that nothing broke I also (let claude) created a comprehensive runtime test suite which didn't exists before. This is the only the reason the PR adds lines instead of removing them.
Related issues
Closes #66
Checklist
colcon buildSoftwareproject board