docs: add AGENTS.md + CLAUDE.md agent instructions#309
Conversation
Root instruction files for coding agents working in this repo: the hard invariants that break silently (no LLM in the control loop, the single sprint-status write path, the git chokepoint, seeded-skill drift), the two orthogonal adapter/mux seams, dev commands, and a docs index. CLAUDE.md delegates to AGENTS.md and adds only the Claude-Code-specific rule: never edit under .claude/, edit the canonical skill and reseed.
"the orchestrator only ever reads it" was wrong in both directions: the loop's dev skill flips only its story spec's frontmatter status, and the engine mirrors that onto the board via sprintstatus.advance() before verification re-checks the stage. Name that path instead.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughThe PR adds repository-level agent guidance, documents bmad-loop architecture and development practices, adds Claude-specific instructions, and updates README wording to describe orchestrator-managed sprint-status synchronization and verification. ChangesRepository guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryDocs-only PR adding two root agent-instruction files (
Confidence Score: 5/5Docs-only change with no runtime impact; all technical assertions cross-check against the source code. Every factual claim in AGENTS.md was verified against the actual source — ExitCode values match cli.py exactly, _run_git lives in verify.py, sprint_advance is called from engine.py _post_dev_state_sync, asyncio_mode=auto is set in pyproject.toml, both conftest fixtures exist, and all 14+ relative links resolve to real files. The README correction is accurate. No code is modified. Files Needing Attention: No files require special attention; all three changed files are documentation only.
|
| Filename | Overview |
|---|---|
| AGENTS.md | New 94-line agent instructions file; all technical claims verified against the codebase (ExitCode values, _run_git chokepoint, sprint_advance write path, asyncio_mode, conftest fixtures, module table). All relative links resolve. |
| CLAUDE.md | New 7-line file using @AGENTS.md include directive plus one Claude Code–specific rule about canonical skill editing; scripts/seed_skills.py confirmed present. |
| README.md | Single bullet corrected from 'orchestrator only reads sprint-status.yaml' to the accurate description; confirmed by engine.py _post_dev_state_sync → sprint_advance() call chain. |
Reviews (1): Last reviewed commit: "docs(readme): state the sprint-status si..." | Re-trigger Greptile
What
Adds the two root agent-instruction files this repo has been missing, plus one README wording fix they exposed.
AGENTS.md(94 lines) — what a coding agent needs before its first edit here:Stop/window death,sprintstatus.advance()as the sole write path to the board, the_run_gitchokepoint, new policy fields needing asettings/core.tomlentry, canonical-vs-seeded skills, the--jsonschema contract, closedExitCodeallocation, tmux argv quarantine.CLAUDE.md(7 lines) —@AGENTS.mdplus the one Claude-Code-specific rule: never edit under.claude/; edit the canonical skill insrc/bmad_loop/data/skills/and runscripts/seed_skills.py.Both were fact-checked line by line against the code — every claim traced to the module that enforces it, generic doctrine and CONTRIBUTING duplicates cut. All 12 relative links resolve.
The README fix (second commit — separable)
Auditing AGENTS.md against the code showed README.md:34 was wrong in both directions:
The loop's dev skill doesn't touch
sprint-status.yamlat all — it flips its story spec's frontmatter, and the engine mirrors that onto the board (engine.py_post_dev_state_sync→sprint_advance) beforeverify_devgates on the stage. So the orchestrator plainly does write it. Replaced with the accurate invariant —advance()is the single idempotent, never-regress writer — which is also what AGENTS.md records.Happy to drop that commit if you'd rather keep this PR to just the two new files.
Notes
trunk checkclean.Summary by CodeRabbit