Skip to content

cli http tests: allow response header capture#190

Merged
theodore-s-beers merged 2 commits into
mainfrom
tsb_cli_response_headers
Jun 9, 2026
Merged

cli http tests: allow response header capture#190
theodore-s-beers merged 2 commits into
mainfrom
tsb_cli_response_headers

Conversation

@theodore-s-beers

Copy link
Copy Markdown
Member

need something like this for an upcoming course. there is a corresponding pr for the backend.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for capturing values from HTTP response headers into CLI variables (useful for flows like extracting a session id from Set-Cookie), and introduces an option to disable redirect following so learners can assert against intermediate redirect responses.

Changes:

  • Extend HTTP lesson step schema to include ResponseHeaderVariables and FollowRedirects.
  • Capture header-derived variables during runHTTPRequest and render them in the “Variables Saved/Missing” sections.
  • Add tests covering response-header capture and redirect disabling.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
render/view.go Refactors newline rendering in CLI output (switches to WriteByte / WriteString).
render/variables.go Renders saved/missing variables sourced from response headers and adds header-variable descriptions.
render/variables_test.go Updates variable-section tests to include response header variables.
client/lessons.go Updates the lesson/step data model for ResponseHeaderVariables and FollowRedirects.
checks/http.go Implements redirect disabling and response-header variable extraction during HTTP steps.
checks/http_test.go Adds integration-style test for header capture + no-redirect behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread checks/http.go
Comment thread checks/http.go
Comment thread checks/http.go Outdated
@theodore-s-beers theodore-s-beers force-pushed the tsb_cli_response_headers branch from 7b6397c to 982d55e Compare June 9, 2026 15:31
@theodore-s-beers theodore-s-beers force-pushed the tsb_cli_response_headers branch from 982d55e to 54d5784 Compare June 9, 2026 15:35
@theodore-s-beers theodore-s-beers merged commit e5931e5 into main Jun 9, 2026
1 check passed
@theodore-s-beers theodore-s-beers deleted the tsb_cli_response_headers branch June 9, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants