cli http tests: allow response header capture#190
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for capturing values from HTTP response headers into CLI variables (useful for flows like extracting a session id from Set-Cookie), and introduces an option to disable redirect following so learners can assert against intermediate redirect responses.
Changes:
- Extend HTTP lesson step schema to include
ResponseHeaderVariablesandFollowRedirects. - Capture header-derived variables during
runHTTPRequestand render them in the “Variables Saved/Missing” sections. - Add tests covering response-header capture and redirect disabling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
render/view.go |
Refactors newline rendering in CLI output (switches to WriteByte / WriteString). |
render/variables.go |
Renders saved/missing variables sourced from response headers and adds header-variable descriptions. |
render/variables_test.go |
Updates variable-section tests to include response header variables. |
client/lessons.go |
Updates the lesson/step data model for ResponseHeaderVariables and FollowRedirects. |
checks/http.go |
Implements redirect disabling and response-header variable extraction during HTTP steps. |
checks/http_test.go |
Adds integration-style test for header capture + no-redirect behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7b6397c to
982d55e
Compare
982d55e to
54d5784
Compare
squashd
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
need something like this for an upcoming course. there is a corresponding pr for the backend.