Skip to content

feat: check access for keytar write operation#694

Merged
congminh1254 merged 1 commit into
mainfrom
check-write-access-keytar
Jun 3, 2026
Merged

feat: check access for keytar write operation#694
congminh1254 merged 1 commit into
mainfrom
check-write-access-keytar

Conversation

@congminh1254
Copy link
Copy Markdown
Member

No description provided.

@congminh1254 congminh1254 requested a review from a team June 3, 2026 10:51
@congminh1254 congminh1254 changed the title feat: check access for keytar write operation feat: check access for keytar write operation Jun 3, 2026
Copy link
Copy Markdown
Contributor

@arjankowski arjankowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26880003845

Coverage decreased (-0.02%) to 84.943%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: 2 uncovered changes across 1 file (3 of 5 lines covered, 60.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/secure-storage.js 5 3 60.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 6056
Covered Lines: 5395
Line Coverage: 89.09%
Relevant Branches: 2153
Covered Branches: 1578
Branch Coverage: 73.29%
Branches in Coverage %: Yes
Coverage Strength: 642.83 hits per line

💛 - Coveralls

@congminh1254 congminh1254 merged commit 29e5cc9 into main Jun 3, 2026
20 of 21 checks passed
@congminh1254 congminh1254 deleted the check-write-access-keytar branch June 3, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants