Fix slug heading styles in Heading component#613
Closed
arpitjain099 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
arpitjain099
requested review from
anselmbradford,
billhimmelsbach,
contolini,
flacoman91 and
natalia-fitzgerald
as code owners
Collaborator
|
Thanks @arpitjain099 ! This is actually a great catch. the included scss is necessary for the published library. It may seem okay in storybook since it loads everything in a _shared.scss |
Collaborator
|
For some reason our automatic tests wont run on forks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Slug heading markup has the right classes now, but the DS slug stylesheet was not being pulled into DSR, so the component could still render without the expected border and typography treatment.
This updates Heading to import the DS slug-header styles, tightens the slug unit test to assert the real BEM class, and adds a Storybook play assertion for the slug wrapper and heading classes.
Verified locally with:
Closes #578