fix(imap): do not bubble up errors in IMAP candidate loop#8420
Merged
Conversation
j-g00da
approved these changes
Jul 15, 2026
link2xt
force-pushed
the
link2xt/ouswksvxkspx
branch
2 times, most recently
from
July 16, 2026 07:51
e48ebc2 to
9951265
Compare
Network errors such as timeouts should not break out of the loop by bubbling up errors. There may be more candidates to try, breaking out of the loop skips trying them.
The loop is large, so having an explicit label makes it easier to understand what the "continue" statement does.
link2xt
changed the title
link2xt
force-pushed
the
link2xt/ouswksvxkspx
branch
from
July 16, 2026 08:16
9951265 to
0462e12
Compare
j-g00da
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Network errors such as timeouts should not break out of the loop by bubbling up errors. There may be more candidates to try, breaking out of the loop skips trying them.