refactor: change useForm on ShiftOptionsPanel#4263
Closed
Sebastien-Ahkrin wants to merge 1 commit into
Closed
Conversation
Deploying nmrium with
|
| Latest commit: |
37867d3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://492b9ba0.nmrium.pages.dev |
| Branch Preview URL: | https://4185-refactor-useform-on-shi.nmrium.pages.dev |
tpoisseau
reviewed
Jul 10, 2026
tpoisseau
left a comment
tpoisseau
left a comment
Contributor
There was a problem hiding this comment.
I hope it is your first form in filters panel, else I'm sorry.
My current work is to refactor current filters system to the new processings system.
It includes options edition UI ported to plugins (with tanstack form).
If you want port theses forms, please follows https://github.com/zakodium/nmrium/issues/797 and https://github.com/zakodium/nmrium/issues/775
You can abandon this PR, and skip all forms inside src/component/panels/filtersPanel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #4185