ci: add chronicle-image-pin-gate (block bare chronicle default images)#317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
chronicle-image-pin-gatecheck: a changed chart must not render a bare (un-digest-pinned)ghcr.io/chronicleprotocol/*image.Why
Chart defaults authored with an empty
tag:(which falls back to.Chart.AppVersion, a bare tag) or a bare version are unpinned. With thechronicle-resolve-digestmutating webhook adding the digest on live pods, that causes perpetual ArgoCD OutOfSync (the ghost / validator / groma incidents) and violates RFC-044.4 (chart defaults must be index-digest-pinned). app-of-apps already has adigest-gate; the chart repos did not.How
On chart PRs,
helm templateeach changed chart (with itsci/values) and fail if any renderedghcr.io/chronicleprotocol/*image lacks@sha256:. Rendering (not a line diff) is what catches the empty-tag -> appVersion case. Third-party images are not gated; un-renderable charts are warned and skipped (ct lint already covers templating).Rollout
Lands non-blocking (not yet a required check). Suggest letting it run on a few chart PRs, then adding it to branch protection as required (RFC-044.4 prevention).