ci: pin-gate fail closed on git-diff error#320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mirror the app-of-apps #1624 fail-OPEN fix in the chart-repo pin gate.
Why
changed=$(git diff --name-only "${BASE_SHA}...HEAD" ...)returned empty on a git error (the run block setspipefailbut noterrexit), so a broken / unreachable-base diff yielded "No chart changes." -> exit 0 -> the required gate PASSED. Same class as the app-of-apps fail-open that #1622 exposed.How
Wrap the diff in
if ! changed=$(...); then echo ::error::...; exit 1; fi. Withpipefail, a git-diff error now fails the check (fail-closed) instead of silently passing.bash -nclean; no other change. (The gate already uses the immutableBASE_SHA, so it was less fragile than app-of-apps, but the empty-diff pass was still reachable.)