Reconnect 13.4-1 as an upgrade node for the 14.x path#8650
Open
ihalatci wants to merge 1 commit into
Open
Conversation
A released 13.4 cluster could not ALTER EXTENSION citus UPDATE into the 14.x line because 13.4-1 had no incident SQL scripts, so it was not a node in the extension update graph and Postgres path-finding failed with "no update path". Add empty version-bump scripts (byte-identical mirrors of release-13.2's) so 13.4-1 becomes a resolvable node: sql/citus--13.3-1--13.4-1.sql and sql/downgrades/citus--13.4-1--13.3-1.sql. Add a no-op 13.3->13.4->13.3 excursion to multi_extension; it leaves prev_objects at 13.3 so print_extension_changes() returns (0 rows) and downstream output is unaffected. Verified by a clean multi_extension regression on release-14.0. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-14.0 #8650 +/- ##
================================================
- Coverage 88.63% 88.62% -0.02%
================================================
Files 288 288
Lines 64115 64120 +5
Branches 8045 8045
================================================
- Hits 56831 56826 -5
- Misses 4965 4971 +6
- Partials 2319 2323 +4 🚀 New features to boost your workflow:
|
ihalatci
marked this pull request as ready for review
July 16, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A GA''d
13.4cluster cannotALTER EXTENSION citus UPDATEinto the 14.x line.13.4-1has no incident SQL scripts, so it is not a node in the extension update graph and Postgres path-finding fails with"no update path".multi_extensionupgrade tests do not catch this because they only walk edges that are present in the graph.Fix
Reconnect
13.4-1as a node by adding two empty version-bump scripts, byte-identical to the pattern already shipped onrelease-13.2:src/backend/distributed/sql/citus--13.3-1--13.4-1.sql(forward)src/backend/distributed/sql/downgrades/citus--13.4-1--13.3-1.sql(downgrade)Plus a no-op
multi_extensiontest excursion (13.3 -> 13.4 -> 13.3) asserting the reconnection is a pure no-op.The Makefile auto-globs
sql/*.sqlandsql/downgrades/*.sql, so the new scripts install with no Makefile change.Verification
origin/release-13.2.multi_extensionregression: clean pass, no diffs.prev_objectsat 13.3, so all downstream.outoutput is provably unaffected ->(0 rows).Scope: 4 files, +19 lines -- only the 13.4-1 reconnection; no other edits.