Stabilize PG19 ORDER BY pushdown regression plan#8680
Open
ihalatci wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd1ff9e9-2f27-43d3-b9d7-f7d167e7e3c4
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: bd1ff9e9-2f27-43d3-b9d7-f7d167e7e3c4
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## pg19-support #8680 +/- ##
=============================================
Coverage 88.79% 88.80%
=============================================
Files 288 288
Lines 64416 64416
Branches 8101 8101
=============================================
+ Hits 57201 57205 +4
+ Misses 4877 4874 -3
+ Partials 2338 2337 -1 🚀 New features to boost your workflow:
|
ihalatci
marked this pull request as ready for review
July 17, 2026 11:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilize PostgreSQL 19 ORDER BY pushdown plan assertions ## Context PostgreSQL BUG #19517 caused eager aggregation on semi/antijoin inner relations to return incorrect results on 19beta1 (
5|130). Upstream commitffeda04259bbfixes that bug, and the same reproducer returns the correct5|26on 19beta2. This PR therefore does not disableenable_eager_aggregateorenable_hashaggglobally or in the regression harness. The H4 case inmulti_orderby_pushdownis independent of that correctness fix. On 19beta2, with eager aggregation at its default, it still chooses a workerNested Loopplan instead of the assertedSort -> Hash Semi Joinshape. BothCitus Sorted Merge Adaptivenodes remain, so pushdown itself is intact. This change stabilizes only the H4 EXPLAIN by wrapping it in a transaction and propagating transaction-local planner settings:sql BEGIN; SET LOCAL citus.propagate_set_commands TO 'local'; SET LOCAL enable_nestloop TO off; -- existing H4 EXPLAIN COMMIT;The expected plan is otherwise unchanged and continues to assert sorted-merge pushdown and the worker hash semi-join shape. There are no production-code or regression-harness changes. ## Validation - PostgreSQL 17.10:-Werrorbuild and focusedmulti_orderby_pushdownpath, 15/15 passed. - PostgreSQL 18.4:-Werrorbuild and focused path, 15/15 passed. - PostgreSQL 19beta2:-Werrorbuild and focused path, 15/15 passed with defaultenable_eager_aggregate=on. - PostgreSQL 19beta2 upstream regression suite: 245/245 passed, includingeager_aggregate. - PostgreSQL 19beta2 Citus semi/antijoin path:multi_subquery_in_where_reference_clause, 15/15 passed with eager aggregation enabled. - Perl syntax, style, and diff whitespace checks passed. Closes #8666 > This draft targets the non-defaultpg19-supportbranch. GitHub may defer automatic issue closure until the change reaches the default branch.