Only link -lintl on MinGW#439
Open
rjd15372 wants to merge 1 commit into
Open
Conversation
Commit d1f714f ("Add dep to -lintl to compile under mingw64") added `-lintl` unconditionally to `SHLIB_LINK`. On glibc-based Linux systems the gettext functions are provided by libc itself and there is no separate libintl.so, so every Linux build now fails at link time with: ``` /usr/bin/ld: cannot find -lintl: No such file or directory ``` Windows builds are served by the dedicated `Makefile.win`, which already links libintl explicitly, so the PGXS `Makefile` does not need to carry the flag. Remove it to restore the previous behaviour on all other platforms. Signed-off-by: Ricardo Dias <ricardo.dias@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit d1f714f ("Add dep to -lintl to compile under mingw64") added
-lintlunconditionally toSHLIB_LINK. On glibc-based Linux systems the gettext functions are provided by libc itself and there is no separate libintl.so, so every Linux build now fails at link time with:Windows builds are served by the dedicated
Makefile.win, which already links libintl explicitly, so the PGXSMakefiledoes not need to carry the flag. Remove it to restore the previous behaviour on all other platforms.