fix(shared): Added support for global navigator check to isValidBrowser#8827
Open
royanger wants to merge 2 commits into
Open
fix(shared): Added support for global navigator check to isValidBrowser#8827royanger wants to merge 2 commits into
royanger wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: d7130c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
royanger
changed the title
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Contributor
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
tmilewski
requested changes
Jun 11, 2026
Comment on lines
+64
to
+73
| function getNavigator(): Navigator | null { | ||
| if (typeof window !== 'undefined' && window.navigator) { | ||
| return window.navigator; | ||
| } | ||
| if (typeof navigator !== 'undefined') { | ||
| return navigator; | ||
| } | ||
| return null; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I threw this at Codex and it suggested narrowing the fallback to browser worker globals, not "anything with a global navigator."
This should preserves existing browser behavior, enable MV3/service-worker WorkerNavigator, and keep Node SSR false even though modern Node exposes globalThis.navigator.
Suggested change
| function getNavigator(): Navigator | null { | |
| if (typeof window !== 'undefined' && window.navigator) { | |
| return window.navigator; | |
| } | |
| if (typeof navigator !== 'undefined') { | |
| return navigator; | |
| } | |
| return null; | |
| } | |
| function inBrowserWorker(): boolean { | |
| return typeof WorkerGlobalScope !== 'undefined' && globalThis instanceof WorkerGlobalScope; | |
| } | |
| function getNavigator(): Navigator | null { | |
| if (typeof window !== 'undefined' && window.navigator) { | |
| return window.navigator; | |
| } | |
| if (inBrowserWorker() && typeof globalThis.navigator !== 'undefined') { | |
| return globalThis.navigator; | |
| } | |
| return null; | |
| } | |
Comment on lines
+41
to
50
| it('returns false when there is no window and no navigator (e.g. SSR)', () => { | ||
| const windowSpy = vi.spyOn(global, 'window', 'get'); | ||
| // @ts-ignore - Test | ||
| windowSpy.mockReturnValue(undefined); | ||
| const navigatorSpy = vi.spyOn(global, 'navigator', 'get'); | ||
| // @ts-ignore - Test | ||
| navigatorSpy.mockReturnValue(undefined); | ||
|
|
||
| expect(isValidBrowser()).toBe(false); | ||
| }); |
Member
There was a problem hiding this comment.
See: Suggestions in browser.ts
Suggested change
| it('returns false when there is no window and no navigator (e.g. SSR)', () => { | |
| const windowSpy = vi.spyOn(global, 'window', 'get'); | |
| // @ts-ignore - Test | |
| windowSpy.mockReturnValue(undefined); | |
| const navigatorSpy = vi.spyOn(global, 'navigator', 'get'); | |
| // @ts-ignore - Test | |
| navigatorSpy.mockReturnValue(undefined); | |
| expect(isValidBrowser()).toBe(false); | |
| }); | |
| it('returns false when no window but a non-worker global navigator exists (Node SSR)', () => { | |
| vi.spyOn(global, 'window', 'get').mockReturnValue(undefined as any); | |
| vi.spyOn(globalThis, 'navigator', 'get').mockReturnValue({ userAgent: 'Node.js/25' } as Navigator); | |
| expect(isValidBrowser()).toBe(false); | |
| expect(isValidBrowserOnline()).toBe(false); | |
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit