[Pending SDK Changes] AI Search agent sdks#31892
Draft
aninibread wants to merge 2 commits into
Draft
Conversation
aninibread
requested review from
a team,
G4brym,
irvinebroque,
mchenco and
rita3ko
as code owners
Contributor
Review
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsChecks PR title, description, and redirect checklist. Warnings (2)
Style Guide ReviewNo style-guide issues found. RedirectsNo missing redirect entries found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 issues need attention before merge.
- CRITICAL: PR title contains "[Pending SDK Changes]". Remove this prefix if the dependent SDKs are already released, or convert the PR to draft if they are not.
- HIGH:
agents-sdk.mdxlinks to/ai-search/how-to/human-in-the-loop-knowledge-base/(line 236), but that target page does not exist. - MEDIUM: PR description is empty. Fill in the summary and address the checklist, including whether this change needs a changelog entry.
|
|
||
| <LinkCard | ||
| title="Human-in-the-loop knowledge base updates" | ||
| href="/ai-search/how-to/human-in-the-loop-knowledge-base/" |
Contributor
There was a problem hiding this comment.
This href points to /ai-search/how-to/human-in-the-loop-knowledge-base/, which does not exist. Either remove this LinkCard or correct the path.
Contributor
|
Posted a review on PR #31892. Summary of changes
Labels Issues flagged
I posted 1 inline comment on the broken link and a review-level comment covering the rest. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots (optional)
Documentation checklist