fix: reduce startupProbe periodSeconds without losing failure tolerance#992
Merged
Conversation
dosubot
Bot
added
size:XS
Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>
NiccoloFei
force-pushed
the
dev/startup-probe-period
branch
from
3e68e2f to
5aef349
Compare
leonardoce
approved these changes
Jul 8, 2026
mnencia
approved these changes
Jul 8, 2026
The 1s periodSeconds keeps the common case fast, since the probe is a local unix socket call that normally succeeds in milliseconds. A unix socket connection essentially never times out under mere load, so hitting the timeout implies the sidecar is genuinely unresponsive rather than just slow; raising failureThreshold gives that rare case more patience before restarting the container. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
leonardoce
approved these changes
Jul 9, 2026
mnencia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The startup probe for the injected plugin-barman-cloud sidecar previously left
periodSecondsunset, so the API server defaulted it to 10s. Because the sidecar is a native init container that gates the main postgres container on reachingStarted, this added roughly one full period to every pod's startup, even though the probe itself (a local unix-socket health check) normally succeeds in milliseconds.periodSecondsis now 1s, so the probe reports success almost immediately in the common case. To avoid trading away failure tolerance for that faster common case,failureThresholdis raised to 30 andtimeoutSecondsis lowered to 5s: a unix-socket call essentially never times out under mere load, so hitting the timeout means the sidecar is genuinely unresponsive rather than just slow, and it's fine to give that rare case more attempts before restarting the container.Closes #991