Skip to content

Add Joey the Green and Pink cow#48

Merged
oohwooh merged 3 commits into
codeday:mainfrom
import-graf:add-Maxwell-cow
Jul 18, 2026
Merged

Add Joey the Green and Pink cow#48
oohwooh merged 3 commits into
codeday:mainfrom
import-graf:add-Maxwell-cow

Conversation

@import-graf

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #48

Check PR is going to correct repo passed!
❌ Image path in describe_cow.json must start with "images/".
❌ Image file green_pink_cow.png specified in describe_cow.json does not exist in the PR.
❌ Image file is too large! Maximum allowed size is 200 KB. Please resize or compress it and update your PR.
❌ Image file name in describe_cow.json should be based on the cow's name. Expected: images/alien.png or .jpg or .jpeg
❌ File describe_cow.json is not properly indented.
Check line endings passed!


❌ 2/7 passed. Please fix the issues above and update your PR.

@cla-assistant

cla-assistant Bot commented Jul 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #48

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
Check image file size passed!
❌ Image file name in describe_cow.json should be based on the cow's name. Expected: images/alien.png or .jpg or .jpeg
❌ File describe_cow.json is not properly indented.
Check line endings passed!


❌ 5/7 passed. Please fix the issues above and update your PR.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #48

Check PR is going to correct repo passed!
Check image path passed!
Check image file exists passed!
Check image file size passed!
Check file naming convention passed!
Check proper indentation passed!
Check line endings passed!


✅ All tests passed! Nice work on your PR! 🎉

@oohwooh

oohwooh commented Jul 18, 2026

Copy link
Copy Markdown
Member

Thanks so much for the cow-tribution!

@oohwooh
oohwooh merged commit 925175a into codeday:main Jul 18, 2026
2 checks passed
@import-graf
import-graf deleted the add-Maxwell-cow branch July 18, 2026 16:24
@oohwooh

oohwooh commented Jul 18, 2026

Copy link
Copy Markdown
Member

@import-graf I just noticed your describe_cow.json file is in the root directory instead of inside /cows/ - this is my fault, I should have seen that in my review.

Can you make another PR to move the file inside the cows directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants