Skip to content

Fix JSON validation to require the cows directory#52

Open
floze-the-genius wants to merge 2 commits into
codeday:mainfrom
floze-the-genius:fix/49-require-cows-directory
Open

Fix JSON validation to require the cows directory#52
floze-the-genius wants to merge 2 commits into
codeday:mainfrom
floze-the-genius:fix/49-require-cows-directory

Conversation

@floze-the-genius

@floze-the-genius floze-the-genius commented Jul 18, 2026

Copy link
Copy Markdown

Summary

  • only treat .json files under cows/ as cow descriptions
  • add regression coverage for root-level and unrelated JSON files
  • run the validator tests in the pull request workflow
  • let validator-only maintenance PRs pass after tests instead of requiring a cow payload

Closes #49.

Testing

  • npm ci
  • npm test (5 tests)
  • node --check .github/scripts/validate-pr.js
  • node --check .github/scripts/validation-helpers.js
  • node --check .github/scripts/validation-helpers.test.js
  • git diff --check

AI assistance disclosure

This fix, its regression tests, and this pull request description were prepared with OpenAI Codex under the contributor account owner’s direction. The submitted change was validated locally with the commands above.

@cla-assistant

cla-assistant Bot commented Jul 18, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

Copy link
Copy Markdown

🧪 PR Validation Results for #52


❌ No JSON file found! Please include your .json file.

@cla-assistant

cla-assistant Bot commented Jul 18, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@oohwooh

oohwooh commented Jul 18, 2026

Copy link
Copy Markdown
Member

Thanks so much for the contribution! I especially appreciate that you disclosed your AI use. It is very helpful context to have as a maintainer.

I am busy attending a conference this/next week but will do my best to review this when I can!

@oohwooh
oohwooh self-requested a review July 18, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON validation doesn't require being inside cows directory

2 participants