chore: update project configuration and add linting/formatting tools by amirabbas-gh · Pull Request #23 · codemod/migrations-template

amirabbas-gh · 2026-06-12T15:16:16Z

Added .lintstagedrc.mjs for linting and formatting staged files.
Introduced .oxfmtrc.json and .oxlintrc.json for formatting and linting configurations.
Created .nvmrc to specify Node.js version 22.
Updated .gitignore to exclude build artifacts and temporary files.
Removed obsolete biome.jsonc and package-lock.json files.
Updated CONTRIBUTING.md and AGENTS.md with new setup instructions and common pitfalls.
Adjusted CI workflows to use pnpm and updated paths for quality checks.
update publish flow:

flowchart TD
  A[Feature PR merged to main] --> B{Pending changesets?}
  B -->|Yes| C[release.yml creates Version Packages PR]
  B -->|Yes| D[publish.yml skips]
  C --> E[Merge Version Packages PR]
  E --> F[publish.yml tags + publishes changed packages]
  B -->|No| G[publish.yml runs but finds nothing new]

Big respect to @AugustinMauroy for the code-quality.yaml action, I took a lot of inspiration from their work when building my own ci.yaml action ❤️

mohab-sameh

@amirabbas-gh Please check the findings below.

mohab-sameh

Some findings

mohab-sameh · 2026-06-12T15:45:23Z

+done < <(find codemods -path '*/node_modules/*' -prune -o -name codemod.yaml -print | sort)
+
+for tag in "${new_tags[@]}"; do
+  git push origin "refs/tags/$tag"


P2: This pushes release tags before the publish job runs. If codemod/publish-action fails after tags have been pushed, a full workflow rerun will see those tags as already released, output changed_dirs=[], and skip publishing. Please decouple publish candidates from tag existence, or push tags only after publishing succeeds.

I think the dependency should be based on the tag, because in this flow the tag should already be published before the publish workflow runs.
What’s your opinion on this, @AugustinMauroy?

mohab-sameh · 2026-06-12T15:45:23Z

+
+Three workflows support quality and releases:
+
+- **`code-quality.yml` — Lint & types:** runs format, lint, and typecheck on every matching PR/push.


P3: This still documents code-quality.yml, but this PR deletes that workflow and replaces it with .github/workflows/ci.yaml. The surrounding text also says PR CI is affected-package and cross-platform, while the new CI is single Ubuntu full-repo checks. Please update this section to match the new workflow.

@mohab-sameh Done

mohab-sameh · 2026-06-12T15:45:31Z

P2: This PR changes codemods/sample-codemod/* but does not include a changeset, while the new policy requires one for codemod package changes. I verified this with pnpm changeset status --since=origin/main, which fails with “Some packages have been changed but no changesets were found.” Please add a real or empty changeset, or add the documented skip mechanism plus CI coverage.

AugustinMauroy · 2026-06-12T18:40:34Z

+jobs:
+  ci:
+    name: CI
+    runs-on: ubuntu-latest


Suggested change

runs-on: ubuntu-latest

runs-on: ubuntu-slim

AugustinMauroy · 2026-06-12T18:41:14Z

+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: pnpm


Suggested change

- uses: actions/setup-node@v4

with:

node-version: 22

cache: pnpm

ubuntu-slim already ship node LTS

AugustinMauroy · 2026-06-12T18:41:49Z

+
+      - run: pnpm run check-types
+
+      - run: pnpm test


check on node/userland-migrations Jacob write a small bash command that only run test on the workspace that require it

AugustinMauroy · 2026-06-12T18:42:39Z

 ├── workflow.yaml
 ├── SKILL.md
 ├── package.json
+├── tsconfig.json


why running it for each codemod ?

…ypechecking

amirabbas-gh · 2026-06-13T14:49:12Z

Thank you so much, @AugustinMauroy, for your excellent review! I've changed ubuntu-latest to ubuntu-slim, and I took inspiration from Jacob's approach for pnpm test so that it only runs for the codemods that have changed. TypeScript is now configured globally for the monorepo as well.

I've carefully addressed all the points you mentioned.

AugustinMauroy · 2026-06-14T08:25:15Z

you should add https://github.com/step-security/harden-runner on publish to have report of network transit and it's help to avoid supply chain attack

@AugustinMauroy I’d prefer to add this to the publish-action. Thanks for the recommendation!

AugustinMauroy · 2026-06-14T08:27:54Z

+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true,
+    "noUncheckedIndexedAccess": true,
+    "esModuleInterop": true


Suggested change

"esModuleInterop": true

"esModuleInterop": true,

"erasableSyntaxOnly": true

it's how node & jssg act on typescript https://www.totaltypescript.com/erasable-syntax-only

@AugustinMauroy fixed

AugustinMauroy

LGMT !

…filtering

chore: update project configuration and add linting/formatting tools

55dd8fa

amirabbas-gh requested review from mohab-sameh and mohebifar June 12, 2026 15:16

amirabbas-gh added 2 commits June 12, 2026 18:48

chore: add CI workflow and enhance codemod file path handling

b1ab9ad

chore: consolidate CI workflows and update Node.js version

fed1fdb

mohab-sameh requested changes Jun 12, 2026

View reviewed changes

AugustinMauroy reviewed Jun 12, 2026

View reviewed changes

chore: update contributing guidelines and project configuration for t…

90dfb04

…ypechecking

chore: refine contributing guidelines and clarify CI workflow details

44c9fa0

amirabbas-gh requested a review from AugustinMauroy June 13, 2026 14:57

AugustinMauroy reviewed Jun 14, 2026

View reviewed changes

AugustinMauroy approved these changes Jun 14, 2026

View reviewed changes

chore: add 'erasableSyntaxOnly' option to TypeScript configuration

3140e7b

amirabbas-gh requested a review from mohab-sameh June 15, 2026 12:01

mohab-sameh approved these changes Jun 15, 2026

View reviewed changes

amirabbas-gh added 2 commits June 15, 2026 16:48

chore: enhance version management by syncing codemod YAML versions

0e5d1ea

chore: disable TypeScript unsafe argument rule and improve YAML path …

a14307a

…filtering

amirabbas-gh merged commit 16f63eb into main Jun 15, 2026
1 check passed


		Three workflows support quality and releases:

		- `code-quality.yml` — Lint & types: runs format, lint, and typecheck on every matching PR/push.

	"esModuleInterop": true
	"esModuleInterop": true,
	"erasableSyntaxOnly": true

Conversation

amirabbas-gh commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mohab-sameh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mohab-sameh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mohab-sameh commented Jun 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirabbas-gh commented Jun 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amirabbas-gh commented Jun 12, 2026 •

edited

Loading

mohab-sameh left a comment •

edited

Loading

mohab-sameh left a comment •

edited

Loading