Skip to content

Load video embed and before/after packs on demand #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tf merged 1 commit into from
Jul 15, 2026
+20 −4
Merged

Load video embed and before/after packs on demand #2448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion entry_types/scrolled/lib/pageflow_scrolled/plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@ def configure(config)

c.revision_components.register(Storyline, create_defaults: true)

['tikTokEmbed', 'twitterEmbed', 'hotspots', 'socialEmbed'].each do |name|
['tikTokEmbed', 'twitterEmbed', 'hotspots', 'socialEmbed',
'videoEmbed', 'inlineBeforeAfter'].each do |name|
c.additional_frontend_packs.register(
"pageflow-scrolled/contentElements/#{name}-frontend",
content_element_type_names: [name]
Expand Down
12 changes: 12 additions & 0 deletions entry_types/scrolled/package/config/webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,18 @@ module.exports = {
'pageflow-scrolled/contentElements/socialEmbed-frontend.css'
]
},
'pageflow-scrolled/contentElements/videoEmbed-frontend': {
import: [
'pageflow-scrolled/contentElements/videoEmbed-frontend',
'pageflow-scrolled/contentElements/videoEmbed-frontend.css'
]
},
'pageflow-scrolled/contentElements/inlineBeforeAfter-frontend': {
import: [
'pageflow-scrolled/contentElements/inlineBeforeAfter-frontend',
'pageflow-scrolled/contentElements/inlineBeforeAfter-frontend.css'
]
},
'pageflow-scrolled/widgets/defaultNavigation': {
import: [
'pageflow-scrolled/widgets/defaultNavigation',
Expand Down
2 changes: 2 additions & 0 deletions entry_types/scrolled/package/contentElements-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import 'pageflow-scrolled/contentElements-frontend';
import 'pageflow-scrolled/contentElements/hotspots-frontend';
import 'pageflow-scrolled/contentElements/inlineBeforeAfter-frontend';
import 'pageflow-scrolled/contentElements/socialEmbed-frontend';
import 'pageflow-scrolled/contentElements/tikTokEmbed-frontend';
import 'pageflow-scrolled/contentElements/twitterEmbed-frontend';
import 'pageflow-scrolled/contentElements/videoEmbed-frontend';
2 changes: 0 additions & 2 deletions entry_types/scrolled/package/src/contentElements/frontend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
import './heading/frontend';
import './inlineBeforeAfter/frontend';
import './inlineImage/frontend';
import './inlineVideo/frontend';
import './inlineAudio/frontend';
import './soundDisclaimer/frontend';
import './textBlock/frontend';
import './videoEmbed/frontend';
import './externalLinkList/frontend';
import './dataWrapperChart/frontend';
import './vrImage/frontend';
Expand Down
5 changes: 4 additions & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,10 @@ const pageflowScrolled = [
}
))),

...(['tikTokEmbed', 'twitterEmbed', 'hotspots', 'socialEmbed'].map(name => (
...([
'tikTokEmbed', 'twitterEmbed', 'hotspots', 'socialEmbed',
'videoEmbed', 'inlineBeforeAfter'
].map(name => (
{
input: `${pageflowScrolledPackageRoot}/src/contentElements/${name}/frontend.js`,
output: {
Expand Down
Loading